Opened 3 years ago
Convert QuerySet to Query when filtering
|Reported by:||akaariai||Owned by:||nobody|
|Component:||Database layer (models, ORM)||Version:||master|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The current ORM coding has very similar, yet not equivalent paths for using QuerySet and the internal Query when doing filter(something=queryset_or_query). It seems that converting a QuerySet to Query early on would lead to cleaner implementation. Proof of concept here: https://github.com/akaariai/django/tree/queryset_to_query_in_filter
There are two problems in the current implementation:
- The way user-defined .values() and Django issued .values() in build_filter() is detected is ugly
- There is no multidb protection (test_subquery in multiple_database.tests.QueryTestCase) fails).
I'll mark this as accepted directly in the sense of "worth doing if above problems can be addressed).