Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#20890 closed Uncategorized (fixed)

Missing View import on a Class Based View Introduction documentation example

Reported by: andre.augustosc@… Owned by: nobody
Component: Documentation Version: 1.5
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: yes UI/UX: no

Description

There's a missing import on a Class Based Views introduction documentation example

The diff is

diff --git a/docs/topics/class-based-views/intro.txt b/docs/topics/class-based-views/intro.txt
index a65b887..eb5f32b 100644
--- a/docs/topics/class-based-views/intro.txt
+++ b/docs/topics/class-based-views/intro.txt
@@ -196,6 +196,7 @@ A basic function-based view that handles forms may look something like this::

 A similar class-based view might look like::

+    from django.views.generic.base import View
     from django.http import HttpResponseRedirect
     from django.shortcuts import render

I've made a pull request on https://github.com/django/django/pull/1462

Change History (3)

comment:1 Changed 21 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In ab680725bfb2f0d79cff26331b30a3d583c55a80:

Fixed #20890 -- Added missing import in class-based view docs.

Thanks André Augusto.

comment:2 Changed 21 months ago by Tim Graham <timograham@…>

In 9e2a2c491b47255dd81735e96186ac237bf9f06e:

[1.5.x] Fixed #20890 -- Added missing import in class-based view docs.

Thanks André Augusto.

Backport of ab680725bf from master

comment:3 Changed 21 months ago by Tim Graham <timograham@…>

In 43f12f368b141444b47aacea2635afbc28ed46d0:

[1.6.x] Fixed #20890 -- Added missing import in class-based view docs.

Thanks André Augusto.

Backport of ab680725bf from master

Note: See TracTickets for help on using tickets.
Back to Top