Password Reset does not catch exception from send_mail

[ezra]

PasswordResetForm.save() method calls send_mail to send the password reset token to the user. Per the documentation, send_mail may raise smtplib.SMTPException. PasswordResetForm class does not handle that exception, and neither the views.password_reset method.

It should be straight forward to catch this exception, and report an appropriate error message to the user.

[ezra]

small patch to catch the excpetion

[ezra]

Attached a potential patch.

[Tim Graham]

Thanks for the patch, however, I think it's a bad idea to introduce a dependency of contrib.messages in contrib.auth. This would also require a test for the new feature.

[Simon Charette]

Thinking of it I'm not sure we should fix this at the form level.

I think that returning a 500 and triggering an admin report (mail_admin, sentry, ...) is the correct way to handle this.

If we choose to display the user a message we must make sure the exception is still triggering an exception report.

[ezra]

I don't know Django core code well enough to recommend the correct way to fix this, however I'd love to inform my users if something goes wrong while they were trying to do something.

[Simon Charette]

@ezra in this case I suggest you read the documentation regarding ​handling of runtime exceptions. You should be able to inform your users something went wrong this way.