Opened 11 years ago
Closed 11 years ago
#20861 closed Bug (fixed)
500 status code debugging view shouldn't localize numeric tags IDs/line numbers
Reported by: | Ramiro Morales | Owned by: | nobody |
---|---|---|---|
Component: | Utilities | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Contributor Kronuz opened a pull request (https://github.com/django/django/pull/451) with a proposed fix to the issue.
I've added tests here: https://github.com/django/django/pull/1437
One thing missing in the proposed fix was importing the l10n
template tag library (the one that contains the unlocalize
filter) and this stopped me from merging the PR right away.
Until now the template is pretty self-contained and lean, e.g. it doesn't import template tag libraries (I suspect to minimize the risk of triggering other problems when trying to show a helpful version of the server error exceptions.)
Should I ignore all this and simply commit the fix?
Change History (2)
comment:1 by , 11 years ago
Has patch: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
New, less invasive (IMHO) strategy: Specify
use_l10n=False
when constructing the Context for the debug view. PR updated.I plan to commit this soon.