AdminEmailHandler does not utilze the 'formatter' setting.

[Daniel Sokolowski]

Emailed log messages through the AdminEmailHandler only include the message as returned by the do record.getMessage() method and omit utilizing the formatter string setting. A patch that will include the formatted log entry in the body of the email will follow shortly.

[Daniel Sokolowski]

Patch in Git pull request: ​https://github.com/django/django/pull/1423

Sample generated email subject:

`[Some Site][Development] ERROR: Refactor this to use QuerySet level solution as per ticket - https://code.djangoproject.com/ticket/20625 - Offer.objects.filter(...).active() != Offer.objects.active.filter(...)`

Sample generated email message:

ERROR django.db.models.manager 2013-08-01 11:58:03,897 manager 6516 -1244890304 /srv/www/django/development.yupi.ca/src/github-danielsokolowski-django-ticket_20625-tailored/django/db/models/manager.py@139: Refactor this to use QuerySet level solution as per ticket - https://code.djangoproject.com/ticket/20625 - Offer.objects.filter(...).active() != Offer.objects.active.filter(...)

No stack trace available

Request repr() unavailable.}}}

[polmuz]

There's something weird with the pull request, I'm seeing 14 extra commits that are not related to this issue.

[Daniel Sokolowski]

You are right - I don't understand why. Regardless here is the original ticket branch: ​https://github.com/danielsokolowski/django/tree/master-ticket-20844

And new pull request here --- well something very odd indeed I can not create a new pull request; I will look into this when I find more time, thanks for pointing out the issue.

[Tim Graham]

I'm not sure about this change as it stands right now. With it, tracebacks are included twice in each email.

[Daniel Sokolowski]

I wanted to keep changes to minimum but for sure agree with you - here is the updated code ​https://github.com/danielsokolowski/django/tree/master-ticket-20844 which does not duplicate the stack trace.

Sample email:

Subject: [Yupi][Development] ERROR (EXTERNAL IP): Internal Server Error: /offers/negotiate/1/1/

WARNING django.db.models.manager 2013-09-12 09:38:02,049 manager 6626 -1244792000 /srv/www/django/development.yupi.ca/src/github-danielsokolowski-django-ticket_20625-tailored/django/db/models/manager.py@139: Refactor this to use QuerySet level solution as per ticket - https://code.djangoproject.com/ticket/20625 - Offer.objects.filter(...).active() != Offer.objects.active.filter(...)

Request repr(): unavailable

Now does anyone is having issue creating git pull requests? I am unable to create a pull request - it just cycles me back to the creation page - tried three different browsers so it does not appear to be a front end issue.

[Tim Graham <timograham@…>]

In ad6fcdb8d24d84a130f847f45b51d7e892ccca08:

Fixed #20844 -- Made AdminEmailHandler respect LOGGING 'formatter' setting.