django.utils.encoding.force_text() should call unicode() instead of __unicode__()
|Reported by:||lie.1296@…||Owned by:||apollo13|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Description (last modified by timo)
Unlike the unicode() builtin function, the method __unicode__() does not validate its return type.
If people wrote a buggy __unicode__ which does not return str or unicode, this can lead to a situation where force_text() will return non-text, and so the bug may only appear much, much later when other parts of the application assumes they were getting text and often it will become very difficult to find how the non-string object came from.
force_text() should be switched to use unicode() so returning non-text from __unicode__() will immediately raise an error at the point where the error would have been obvious.
Change History (4)
comment:3 Changed 19 months ago by mjtamlyn
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:4 Changed 19 months ago by apollo13
- Has patch set
- Owner changed from nobody to apollo13
- Status changed from new to assigned
- Triage Stage changed from Unreviewed to Accepted
- Version changed from 1.5 to master