Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20794 closed Cleanup/optimization (fixed)

Document change of behaviour in validate_email for Django 1.6

Reported by: Dominic Rodger Owned by: nobody
Component: Documentation Version: 1.6-beta-1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

#4833 changed the way validate_email deals with x@localhost emails, which is probably backwards incompatible. Whilst I doubt many people rely on it, it's probably worth noting (it confused me a bit when my tests for https://github.com/dominicrodger/djohno failed in Django 1.6b1).

I've created a pull request (https://github.com/django/django/pull/1394) to add a note to the 1.6 release notes.

Change History (4)

comment:1 Changed 3 years ago by Dominic Rodger

Component: *.djangoproject.comDocumentation
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 3 years ago by Claude Paroz

Triage Stage: UnreviewedReady for checkin
Type: UncategorizedCleanup/optimization
Version: 1.51.6-beta-1

comment:3 Changed 3 years ago by Claude Paroz <claude@…>

Resolution: fixed
Status: newclosed

In c928725b933ff479c04e8a7fb74c4dc2ba138aa7:

Fixed #20794 -- Documented changes to validate_email

4e2e8f39d changed the way validate_email behaves for foo@localhost
email addresses, but wasn't listed in the release notes.

comment:4 Changed 3 years ago by Claude Paroz <claude@…>

In 45d5a4e7d22bb8541dcb8e8dc7d1e951758ac0ad:

[1.6.x] Fixed #20794 -- Documented changes to validate_email

4e2e8f39d changed the way validate_email behaves for foo@localhost
email addresses, but wasn't listed in the release notes.
Backport of c928725b9 from master.

Note: See TracTickets for help on using tickets.
Back to Top