Code

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#20792 closed Bug (fixed)

DISALLOWED_USER_AGENTS is a list of compiled regular expression objects not a list of strings

Reported by: simonb Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords: DISALLOWED_USER_AGENTS
Cc: sesh Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

https://docs.djangoproject.com/en/dev/ref/middleware/ says "Forbids access to user agents in the DISALLOWED_USER_AGENTS setting, which should be a list of strings."

But it's actually expected to be a list of compiled regex objects as stated in the settings docs https://docs.djangoproject.com/en/1.5/ref/settings/#disallowed-user-agents

Attachments (0)

Change History (6)

comment:1 Changed 9 months ago by bmispelon

  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 9 months ago by sesh

  • Cc sesh added

I've added a pull request that fixes this documentation issue:
https://github.com/django/django/pull/1398

comment:3 Changed 9 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In eda39fe704b1b76a94f44b49949660bef2827ed2:

[1.4.x] Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

Backport of dab52d99fc from master

comment:4 Changed 9 months ago by Tim Graham <timograham@…>

In dab52d99fc821f31ab64177551b90d0a513f1eee:

Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

comment:5 Changed 9 months ago by Tim Graham <timograham@…>

In be6d795854b5b3c50d3370720b8eb3861d5ff32f:

[1.5.x] Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

Backport of dab52d99fc from master

comment:6 Changed 9 months ago by Tim Graham <timograham@…>

In 76047498719836c7c33c4610afb21b0d000e1393:

[1.6.x] Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

Backport of dab52d99fc from master

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.