Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#20792 closed Bug (fixed)

DISALLOWED_USER_AGENTS is a list of compiled regular expression objects not a list of strings

Reported by: Simon Blanchard Owned by: nobody
Component: Documentation Version: dev
Severity: Normal Keywords: DISALLOWED_USER_AGENTS
Cc: Brenton Cleeland Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

​https://docs.djangoproject.com/en/dev/ref/middleware/ says "Forbids access to user agents in the DISALLOWED_USER_AGENTS setting, which should be a list of strings."

But it's actually expected to be a list of compiled regex objects as stated in the settings docs ​https://docs.djangoproject.com/en/1.5/ref/settings/#disallowed-user-agents

Change History (6)

comment:1 by Baptiste Mispelon, 11 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted

comment:2 by Brenton Cleeland, 11 years ago

Cc: Brenton Cleeland added

I've added a pull request that fixes this documentation issue:
​https://github.com/django/django/pull/1398

comment:3 by Tim Graham <timograham@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In eda39fe704b1b76a94f44b49949660bef2827ed2:

[1.4.x] Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

Backport of dab52d99fc from master

comment:4 by Tim Graham <timograham@…>, 11 years ago

In dab52d99fc821f31ab64177551b90d0a513f1eee:

Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

comment:5 by Tim Graham <timograham@…>, 11 years ago

In be6d795854b5b3c50d3370720b8eb3861d5ff32f:

[1.5.x] Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

Backport of dab52d99fc from master

comment:6 by Tim Graham <timograham@…>, 11 years ago

In 76047498719836c7c33c4610afb21b0d000e1393:

[1.6.x] Fixed #20792 -- Corrected DISALLOWED_USER_AGENTS docs.

Thanks simonb for the report.

Backport of dab52d99fc from master

Note: See TracTickets for help on using tickets.
Back to Top