Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#20767 closed Bug (fixed)

preserve_filters with namespaces and multiple admins

Reported by: CollinAnderson Owned by: loic84
Component: contrib.admin Version: 1.6-beta-1
Severity: Normal Keywords:
Cc: cmawebsite@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I'm finding that preserve_filters is not working if I add a second admin with a namespace.

I have simple multiple admin project that you can use to use to try it yourself.
https://github.com/collinanderson/multiadmin

I think the problem is happening somewhere around here:
https://github.com/django/django/commit/c86a9b63984f6692d478f6f70e3c78de4ec41814#L0R769

Change History (8)

comment:1 Changed 22 months ago by loic84

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to loic84
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

Thanks for the report and ticket, I can reproduce it.

comment:2 Changed 22 months ago by CollinAnderson

  • Cc cmawebsite@… added

comment:4 Changed 22 months ago by loic84

  • Has patch set

comment:5 Changed 22 months ago by CollinAnderson

This fixes my problem. Thanks so much.

comment:6 Changed 22 months ago by loic84

  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 22 months ago by Simon Charette <charette.s@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 2fc6c9472cd25910f978fe1d18de5c350370f901:

Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs.

Thanks Collin Anderson for the report.

comment:8 Changed 22 months ago by Simon Charette <charette.s@…>

In c660f0e9857e570628e68fa856cc0b613382bd1a:

[1.6.x] Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs.

Thanks Collin Anderson for the report.

Backport of 2fc6c9472c from master.

Note: See TracTickets for help on using tickets.
Back to Top