Code

Opened 8 years ago

Closed 8 years ago

#2072 closed defect (fixed)

the changelists.css file references two styles which are not defined : _height & _margin-right

Reported by: darren.redmond@… Owned by: wilson
Component: Generic views Version:
Severity: normal Keywords: css stylesheet
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This relates to the trunk checked out yesterday June 1st at 14:32 BST.

The changelists.css stylesheet was not displaying correctly on Apache server 2.0.58 viewed via Firefox 1.5.0.4, and there were two style sheet errors in the java script console relating to line 7 (_height) and line 30 (_margin-right).

When I changed the references from _height to height and from _margin-right to margin-right, the ui now displays correctly.

existing line 7 changelists.css:
.change-list .filtered { min-height:400px; _height:400px; }

changed line 7 changelists.css:
.change-list .filtered { min-height:400px; height:400px; }

existing line 30 changelists.css:
#changelist-filter ul { padding-left:0;margin-left:10px;_margin-right:-10px; }

changed line 30:
#changelist-filter ul { padding-left:0;margin-left:10px;margin-right:-10px; }

cheers
Darren

Attachments (0)

Change History (2)

comment:1 Changed 8 years ago by wilson

  • Owner changed from jacob to wilson
  • Status changed from new to assigned

Those are intentional rules to fix rendering bugs in IE. Only IE (6 and earlier) interprets rules preceded by an underscore. I'll move them out to the patch-iewin.css file to avoid further confusion.

comment:2 Changed 8 years ago by wilson

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3064]) Fixed #2072 -- Moved IE hacks out of changelists.css into patch-iewin.css to avoid confusion.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.