Allow widthratio tag to accept "as" parameter to put result in the template context

[clay.evil@…]

<div class="bar" style="width:{% widthratio x y 100 %}%">

{% widthratio x y 100 %}%

</div>

[jonathanslenders]

Is it okay, to make widthratio as follows?

{% widthratio x y 100 as result %}

I'll do it, it's an easy one.

[Tim Graham]

Yes, that's the syntax I'd expect.

[jonathanslenders]

Fixed.

See: ​https://github.com/django/django/pull/1472

[Tim Graham]

Looks good. The addition to AUTHORS should be alphabetized. You also need update the documentation: describe the change in docs/ref/templates/builtins.txt with a .. versionchanged:: 1.7 directive and also mention it in docs/releases/1.7.txt

[clay.evil@…]

Good job, Thank you all!

[jonathanslenders]

New patch in attachment and pull requested updated: ​https://github.com/django/django/pull/1472/files

wait... forgot the docs/releases/1.7.

[jonathanslenders]

Patch + unit tests + docstring updated.

[jonathanslenders]

Should be okay now.

[Tim Graham]

Thanks, looks good. FYI, you don't need to attach a patch *and* send a pull request. Also for future reference, please don't mark your own patch as "Ready for checkin". That needs to be done by a different reviewer. Also be sure to set the "Has Patch" and other flags on the ticket so the ticket is in the right state. See the ​triaging tickets page.

[Tim Graham <timograham@…>]

In ff410565bf1cf1a2905c1ef83db408d455211446:

Fixed #20709 -- Allowed {% widthratio %} to accept an "as" parameter.

Thanks clay.evil@ for the suggestion.

[jonathanslenders]

Oké, thanks timo! I'll do that next time!