#20651 closed Cleanup/optimization (wontfix)
PEP 8 compliance
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Normal | Keywords: | PEP |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
Hello,
Some PEP 8 rules are not respected in /django/dispatch/saferef.py.
Attachments (1)
Change History (3)
by , 11 years ago
Attachment: | pep8.patch added |
---|
comment:1 by , 11 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Thanks for the report, but the ability to merge upstream changes in this file is more important than PEP8 compliance.
Generally speaking:
- many parts of Django do not abide by PEP 8, and we have an explicit policy of following the surrounding style;
- we ask contributors to be very conservative with style cleanups, because it makes patches harder to review;
- patches that are pure style cleanups aren't useful, because it's much faster to redo the work than to review it.
comment:2 by , 11 years ago
... and, you missed the most important point - the first clause in PEP8: A foolish consistency is the hobgoblin of little minds
PEP8 isn't a hard law. It's a style guide, and most importantly, it's a style guide that says sometimes it's OK to break the style guide.
Note:
See TracTickets
for help on using tickets.
Patch file