Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20651 closed Cleanup/optimization (wontfix)

PEP 8 compliance

Reported by: Maxime Arthaud <maxime.arthaud@…> Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords: PEP
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Hello,

Some PEP 8 rules are not respected in /django/dispatch/saferef.py.

Attachments (1)

pep8.patch (4.9 KB) - added by Maxime Arthaud <maxime.arthaud@…> 2 years ago.
Patch file

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by Maxime Arthaud <maxime.arthaud@…>

Patch file

comment:1 Changed 2 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks for the report, but the ability to merge upstream changes in this file is more important than PEP8 compliance.

Generally speaking:

  • many parts of Django do not abide by PEP 8, and we have an explicit policy of following the surrounding style;
  • we ask contributors to be very conservative with style cleanups, because it makes patches harder to review;
  • patches that are pure style cleanups aren't useful, because it's much faster to redo the work than to review it.

comment:2 Changed 2 years ago by russellm

... and, you missed the most important point - the first clause in PEP8: A foolish consistency is the hobgoblin of little minds

PEP8 isn't a hard law. It's a style guide, and most importantly, it's a style guide that says sometimes it's OK to break the style guide.

Note: See TracTickets for help on using tickets.
Back to Top