ModelFormMixin.fields not present in flattened index
|Reported by:||bmispelon||Owned by:||bmispelon|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
f026a519aea8f3ea7ca339bfbbb007e1ee0068b0 introduced the new fields attribute on ModelFormMixin which allows views like CreateView or UpdateView to define which model fields should be present on the dynamically created form.
However, this new attribute was not added to the flattened index page .
Note that technically, the ModelFormMixin does not have a fields attribute, but rather the implementation of ModelFormMixin.get_form_class  does a getattr(self, 'fields', None).
I don't see any reason for using getattr instead of simply declaring the fields attribute on the mixin itself so I think it should be changed too.
Change History (3)
comment:1 Changed 3 years ago by bmispelon
- Has patch set
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset