Code

#20603 closed Cleanup/optimization (fixed)

Make the test suite even faster with available apps

Reported by: aaugustin Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There's a few TestCases that run call_command('syncdb', ...). They would be much faster with a suitable value of available_apps.

As usual the idea is from Anssi: https://github.com/akaariai/django/commit/b101db2d5f738535aef18db73db2a156666346e3

Attachments (0)

Change History (2)

comment:1 Changed 10 months ago by aaugustin

The following hack helps locate culprits:

diff --git a/django/core/management/sql.py b/django/core/management/sql.py
index b58d89f..eeeb483 100644
--- a/django/core/management/sql.py
+++ b/django/core/management/sql.py
@@ -207,6 +207,10 @@ def emit_pre_sync_signal(create_models, verbosity, interactive, db):
 
 def emit_post_sync_signal(created_models, verbosity, interactive, db):
     # Emit the post_sync signal for every application.
+    num_apps = len(models.get_apps())
+    print("post-syncdb on %d apps" % num_apps)
+    if num_apps > 10:
+        import pdb; pdb.set_trace()
     for app in models.get_apps():
         app_name = app.__name__.split('.')[-2]
         if verbosity >= 2:

(Type bt whenever you enter pdb to check which test is running, then c to resume the tests.)

Last edited 10 months ago by aaugustin (previous) (diff)

comment:2 Changed 10 months ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from new to closed

In c3df86661955f218de4788a57338bb23428f5525:

Fixed #20603 -- Made the test suite faster.

By avoiding to run syncdb with the full set of test models.

Thanks Anssi for the idea.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.