Changes between Version 1 and Version 2 of Ticket #20601, comment 6


Ignore:
Timestamp:
Jun 14, 2013, 2:35:21 PM (11 years ago)
Author:
merb

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20601, comment 6

    v1 v2  
    35351,000,11 or 1,000,000,11 which could get converted to an integer, so the next time intcomma gets called, it thinks that the SafeText type could now get converted to an integer and will then return himself.
    3636So this will be an uncorrect return value it should return either the correct output of 1.000.000,11 or nothing since it isn't a valid number. But i think its better to check if isinstance(value, int) and if not it should check if isinstance(value, float) and when nothing is correct it should try to convert to float
     37
     38Even this won't fix it: https://github.com/django/django/pull/785/files
     39Maybe its better to change floatformat to output Decimal
Back to Top