BasePasswordHasher _load_library swallows ImportErrors
|Reported by:||jaap3||Owned by:||nobody|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The _load_library method on BasePasswordHasher turns ImportErrors into ValueErrors, this masks ImportErrors in the algorithm library. I'm proposing a slightly clearer worded error message.
"Couldn't load foo password algorithm library"
"Couldn't load 'FooHasher' algorithm library: No module named bar"
I'll link to a GitHub pull request after I know the ticket number.
Change History (4)
comment:1 Changed 3 years ago by jaap3
- Has patch set
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:3 Changed 3 years ago by Claude Paroz <claude@…>
- Resolution set to fixed
- Status changed from new to closed