Code

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#20585 closed Cleanup/optimization (fixed)

request argument omitted from post method on DeleteView

Reported by: hromby Owned by: batisteo
Component: Generic views Version: 1.5
Severity: Normal Keywords:
Cc: batisteo Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The request argument has been omitted from the post method on the generic DeleteView. Maybe it should be included to have the same arguments for all the handler functions.

Attachments (0)

Change History (5)

comment:1 Changed 10 months ago by henrik.mikkelsen@…

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to anonymous
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 10 months ago by anonymous

  • Owner anonymous deleted
  • Status changed from assigned to new

comment:3 Changed 10 months ago by batisteo

  • Cc batisteo added
  • Owner set to batisteo
  • Status changed from new to assigned

comment:4 Changed 10 months ago by Baptiste Darthenay <baptiste+github@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52f99b78bcc36c4dfdd2870ee139cd5461fb9e91:

Fixed #20585: normalize signature of DeletionMixin.post.

comment:5 Changed 10 months ago by Marc Tamlyn <marc.tamlyn@…>

In 51739c624185b4b45877f521ed5015f2fe01b6e8:

Merge pull request #1258 from batisteo/ticket-20585

Fixed #20585: normalize signature of DeletionMixin.post.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.