Opened 11 years ago
Closed 10 years ago
#20553 closed Cleanup/optimization (fixed)
Useless checks in loadddata [fix in 1.7]
Reported by: | Florian Apolloner | Owned by: | nobody |
---|---|---|---|
Component: | Core (Management commands) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Since [51aa000378c00a442273f01142acdebc94dec68d] Jenkins is failing with:
Traceback (most recent call last): File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/tests/fixtures_regress/tests.py", line 155, in test_absolute_path commit=False File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/core/management/__init__.py", line 161, in call_command return klass.execute(*args, **defaults) File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/core/management/base.py", line 283, in execute output = self.handle(*args, **options) File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/core/management/commands/loaddata.py", line 54, in handle self.loaddata(fixture_labels) File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/core/management/commands/loaddata.py", line 83, in loaddata self.load_label(fixture_label) File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/core/management/commands/loaddata.py", line 118, in load_label for fixture_file, fixture_dir, fixture_name in self.find_fixtures(fixture_label): File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/utils/functional.py", line 32, in wrapper result = func(*args) File "/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2.7/django/core/management/commands/loaddata.py", line 178, in _find_fixtures "serialization format." % tuple(fixture_name.rsplit('.'))) CommandError: Problem installing fixture '/var/lib/jenkins/jobs/Django/workspace/database/sqlite3/python/python2': 7/tests/fixtures_regress/fixtures/absolute is not a known serialization format.
It's currently fixed via [6900cb79dcbc502e0b18476e53ad493b7069ffb8], but this check should really go aways since it prevents me from naming my fixture 'myfixture.v3' or 'myfixture.v3.xml.gz'.
Since we don't want to introduce any backwards incompatible changes post-alpha this will be fixed in 1.7 and this ticket acts as a reminder.
Change History (2)
comment:1 by , 11 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Was fixed by [97ac22ebfca0a5b0759f495cc5d7bed3f9da6615].
Note:
See TracTickets
for help on using tickets.
#20551 is somewhat related. If we change loaddata, then #20551 contains some ideas for even larger changes than this ticket's proposal.