Opened 11 years ago

Closed 11 years ago

#20534 closed Bug (duplicate)

Make TECHNICAL_500 more resilient (against large variables and non-utf-8)

Reported by: Walter Doekes Owned by: nobody
Component: Core (Other) Version: 1.4
Severity: Normal Keywords:
Cc: Walter Doekes Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no



I recently had errors that didn't provide a nice TECHNICAL_500_TEMPLATE mail.

The cause turned out to be two things:
(1) large variables caused a mail so large that the MXs refused to deliver them
(2) non-utf8 representations of objects caused errors while handling the error

The attached fix fixed it.

This was done against Django 1.4. Apologies in advance if this is fixed somewhere already. I couldn't find a relevant bug report.

Triggering (1) should be a matter of generating an error up the stack with a huge variable. Triggering (2) can be done like this:

urlpatterns = (
    # Error test
    (r'500$', (lambda r: Crap())),  # ExplodeInYourFaceError

class Crap(Exception):
    def __init__(self):
        raise self
    def __repr__(self):
        return 'X\xe9X'

Walter Doekes

Attachments (1)

django20534_make_debug_more_resilient.patch (1.0 KB ) - added by Walter Doekes 11 years ago.

Download all attachments as: .zip

Change History (5)

by Walter Doekes, 11 years ago

comment:1 by wim@…, 11 years ago

Triage Stage: UnreviewedAccepted

Good idea to trim large variables.

Shouldn't objects always be presented in utf-8 unicode by default?

comment:2 by Walter Doekes, 11 years ago

Shouldn't objects always be presented in utf-8 unicode by default?

Should and should. In this particular case it was (a) a third party lib (b) throwing an exception with binary data in the representation.

We can argue all day about whether that's right, but error reporting shouldn't choke on it.

comment:3 by Tim Graham, 11 years ago

Duplicate of #20368

comment:4 by Tim Graham, 11 years ago

Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top