Opened 11 years ago
Closed 11 years ago
#20510 closed Bug (invalid)
Form field's label should be unicode
Reported by: | Anssi Kääriäinen | Owned by: | nobody |
---|---|---|---|
Component: | Forms | Version: | 1.6-alpha-1 |
Severity: | Normal | Keywords: | |
Cc: | bmispelon@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Form field's label should always be converted to unicode when using Python 2, even if it is defined as non-unicode string. The conversion is done in 1.5, but not in 1.6-alpha-1. See https://github.com/akaariai/django/commit/88595c900225357756f9d3a6d19be871cd2e5584 and https://github.com/akaariai/django/commit/398d32277f08b20327c5f9955644dfeffe8cae0e for master and stable/1.5.x test cases.
Attachments (1)
Change History (5)
comment:1 by , 11 years ago
Cc: | added |
---|
comment:3 by , 11 years ago
I just don't see what is gained by not doing the conversion in field's init. Django allows mixing unicode and str in a lot of places, so why removing that ability from this place only is a good idea? I can see what is gained by consistent use of unicode strings everywhere in Django, but that isn't gained by the original commit.
Still, I don't feel too strongly about this, so if nobody else complains about this then I don't see a need to act on this ticket.
comment:4 by , 11 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
Nobody seems to be complaining, so closing this.
Looks like this was intended behavior, introduced by 066bf42675040abd7b1a42e5559890e5f9881058.