Code

Opened 14 months ago

Closed 14 months ago

Last modified 11 months ago

#20454 closed Bug (fixed)

Urdu is RTL

Reported by: Pike Owned by: pike
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: pike, jezdez Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In #15300, Urdu was added, but not added to the list of RTL locales. But it is.

References: https://github.com/django/django/blob/master/django/contrib/admin/locale/ur/LC_MESSAGES/django.po shows if you select bidi text, and http://en.wikipedia.org/wiki/Urdu says so.

I'll create a PR

Attachments (0)

Change History (7)

comment:1 Changed 14 months ago by EmilStenstrom

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Looks like a good idea. Marking as Accepted.

Are there tests for RTL languages?

comment:2 Changed 14 months ago by Pike

I had this alllllll written out, but apparently I didn't submit my comment.

I checked, there are some candidates of languages that are also written in RTL, but also in other scripts, and the ones in the tree use non-RTL scripts.

The PR for this ticket is https://github.com/django/django/pull/1142.

I didn't see any existing tests for RTL languages.

comment:3 Changed 14 months ago by Axel Hecht <axel@…>

In 004fde0702957bd73b49313ed17919da71dc909f:

Make Urdu (ur) recognized as RTL language. Refs #20454

comment:4 Changed 14 months ago by Andrew Godwin <andrew@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 2d0e36ae37aa7e017eb4bfe923b3ed3e7a5aa1aa:

Merge pull request #1142 from Pike/master

Fixed #20454: Make Urdu (ur) recognized as RTL language

comment:5 Changed 11 months ago by Joannes

Urdu is still flagged as not bidi in LANG_INFO here: https://github.com/django/django/blob/master/django/conf/locale/__init__.py

comment:6 Changed 11 months ago by Claude Paroz <claude@…>

In e4a67fd90626ced92a61f38ef682d2aa4f34a3ff:

Set 'bidi' Urdu property to True

Refs #20454.

comment:7 Changed 11 months ago by Claude Paroz <claude@…>

In 1d874ce0f94432c1a4b42cacaeb02c5948000d0f:

[1.6.x] Set 'bidi' Urdu property to True

Refs #20454.
Backport of e4a67fd90 from master.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.