#20420 closed Cleanup/optimization (fixed)
Different query counts under Oracle when savepoints are involved
Reported by: | Aymeric Augustin | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
This is a follow-up on #20387, see comments 5 and 6.
In short, Oracle doesn't have RELEASE SAVEPOINT, which means transaction.commit_savepoint()
doesn't do anything. As a consequence, connection.queries
contains one less entry under Oracle than under other databases.
#20387 was fixed by hardcoding the difference into the tests. This ticket is about finding a more robust solution to the general problem.
Change History (4)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
I'm leaning towards stealing the hack Michael Manfre used in django-mssql: https://bitbucket.org/Manfre/django-mssql/src/a2caadaef0ba97faa091dbfe61fe4c04d1e84188/sqlserver_ado/base.py?at=default#cl-345
Pull request: https://github.com/django/django/pull/2777