Code

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#20413 closed Bug (fixed)

respect Query.get_meta()

Reported by: carbonXT Owned by: carbonXT
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: no UI/UX: no

Description

In django.db.models.sql.query.Query there's a get_meta(self) method that's present to aid in subclassing Query. See https://github.com/django/django/blob/master/django/db/models/sql/query.py#L206. Problem is, Query itself as well as its subclasses aren't using this method everywhere they could be... rather they're going around it and accessing its default return value directly. This breaks subclassing Query and overriding get_meta.

I will submit a pull request shortly with mods to Query and friends to respect this method.

Attachments (0)

Change History (2)

comment:1 Changed 11 months ago by Mike Fogel <mike@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 74f3884ae04ea57baee9b04ab0b5658a97cfd296:

Fixed #20413 - Respect Query.get_meta()

comment:2 Changed 11 months ago by Alex Gaynor <alex.gaynor@…>

In c0c3b65de99d638efcb971702a88be42f388989a:

Merge pull request #1069 from mfogel/ticket_20413

Fixed #20413 - Respect Query.get_meta()

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.