Opened 11 years ago
Closed 11 years ago
#20357 closed Bug (fixed)
Check username field label for None
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.auth | Version: | dev |
| Severity: | Normal | Keywords: | python |
| Cc: | stefan.berder@… | Triage Stage: | Ready for checkin |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Sometimes when designing "log-in" forms, there is a necessity to hide the labels and use input element placeholders to identify the fields. When I entered the following in my form:
username = CharField(label='')
the generated HTML still contained the Username <label> element.
It turns out that in line 173 of django.contrib.auth.forms, the boolean test is too broad/generic. It does not take into consideration when the label is deliberately set to an empty string.
The fix to this would affect django/contrib/auth/forms.py file.
I have created a pull request in github: #1046.
Change History (3)
comment:1 by , 11 years ago
| Needs tests: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.5 → master |
comment:2 by , 11 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:3 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
PR looks RFC, will commit soon.