TestCase will let code rollback and commit without warning

[uberj@…]

The docs for ​TransactionTestCase say TestCase "prevents the code under test from issuing any commit or rollback operations on the database". Code running in a TestCase that uses commit or rollback will still appear to work. Of course, those functions don't do anything, they have been replaced by a nop function that silently does nothing -- see ​here.

The 'silently' part does not help a user that is using TestCase but should be using TransactionTestCase.

[uberj@…]

In a perfect world, I would like to see at least one of the following happen:

• nop raise an exception warning the user that they should be using TransactionTestCase
• A print statement warning the user
• The docs on TransactionTestCase updated to not use the word 'prevents', and mention something about how functions like commit and rollback are essentially callable nops when used in a TestCase.

[Simon Charette]

Unfortunately first and second options are no-go since there's no reliable way to differentiate implicit from explicit commit and rollback calls.

i.e. You'd like explicit transaction.commit call to raise an exception or a warning but not the implicit calls from Model().save().

It would also be highly backward incompatible.

Third option seems reasonable, a documentation patch is welcome!

[anonymous]

I've changed the docs, basically restating what the ticket author has already said.
patch at: ​https://github.com/lolek09/django/commit/2df87c45496bf7a9e2da109ffee20d50b40af042.patch
graphic diff: ​https://github.com/lolek09/django/commit/2df87c45496bf7a9e2da109ffee20d50b40af042

[Tim Graham <timograham@…>]

In dffdca1109a2111f104f2419d081c0f971537fec:

Fixed #20316 - Clarified transaction behavior of TestCase.

Thanks uberj@ for the report and lolek09 for the patch.

[Tim Graham <timograham@…>]

In cd15a51c3eb2918107814e7c42533ebef982a431:

[1.5.x] Fixed #20316 - Clarified transaction behavior of TestCase.

Thanks uberj@ for the report and lolek09 for the patch.

Backport of dffdca1109 from master