Opened 11 years ago

Closed 11 years ago

#20311 closed Bug (fixed)

Avoid double Plural-Forms entry in translation files

Reported by: naktinis@… Owned by: nobody
Component: Internationalization Version: 1.5
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since xgettext already generates plural form entry, we have to make sure we remove the template before adding the correct plural form.

Without this fix makemessages command would generate:
...
"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
"Plural-Forms: nplurals=1; plural=0\n"
...

Attachments (1)

patch​ (1003 bytes ) - added by naktinis@… 11 years ago.
Patch

Download all attachments as: .zip

Change History (4)

by naktinis@…, 11 years ago

Attachment: patch​ added

Patch

comment:1 by Claude Paroz, 11 years ago

Needs tests: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

comment:2 by Claude Paroz, 11 years ago

I guess this was unnoticed because it happens only if the first processed file contains plural strings.

comment:3 by Ramiro Morales <cramm0@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 1559f84d8b5c2d4d088a27fc0edf02f01a1d65f0:

Fixed #20311 -- Make sure makemessages doesn't create duplicate Plural-Forms .po file headers.

Thanks naktinis for the report and initial patch.

Note: See TracTickets for help on using tickets.
Back to Top