Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#2029 closed (fixed)

[patch] Fix sorting models by verbose_name_plural in get_admin_app_list template tag

Reported by: Alex Dedul Owned by: Adrian Holovaty
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Now it sorts models just by doing model_list.sort() and it don't work when you have custom verbose_name_plural set in your model, for example in UserProfile model verbose_name_plural set to 'address book'. Patch below fixes this to correctly sort based on verbose_name_plural.

Attachments (2)

admin_model_list_sort_by_name.patch​ (1007 bytes ) - added by Alex Dedul 19 years ago.
admin_model_list_sort_by_name_fixed_typo.patch​ (1009 bytes ) - added by Alex Dedul 19 years ago.
Fixed typo in comments

Download all attachments as: .zip

Change History (4)

by Alex Dedul, 19 years ago

Attachment: admin_model_list_sort_by_name.patch​ added

by Alex Dedul, 19 years ago

Attachment: admin_model_list_sort_by_name_fixed_typo.patch​ added

Fixed typo in comments

comment:1 by Luke Plant, 19 years ago

Resolution: → fixed
Status: new → closed

(In [2999]) Fixed #2029 - models now sorted by verbose_name_plural in get_admin_app_list - thanks Alex Dedul.

comment:2 by Here, 19 years ago

Type: defect
Note: See TracTickets for help on using tickets.
Back to Top