Opened 23 months ago

Closed 22 months ago

Last modified 22 months ago

#20256 closed Bug (fixed)

Incorrect text in startproject command line help

Reported by: anonymous Owned by: n0nam3
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The command line help for startproject django-admin.py startproject --help is

  --template=TEMPLATE   The dotted import path to load the template from.

The directory need not to be importable and should not be dotted but a path with "/".

--- a/django/core/management/templates.py
+++ b/django/core/management/templates.py
@@ -43,7 +43,7 @@ class TemplateCommand(BaseCommand):
     option_list = BaseCommand.option_list + (
         make_option('--template',
                     action='store', dest='template',
-                    help='The dotted import path to load the template from.'),
+                    help='The path or url to load the template from.'),
         make_option('--extension', '-e', dest='extensions',
                     action='append', default=['py'],
                     help='The file extension(s) to render (default: "py"). '

Attachments (1)

incorrect_text.diff (737 bytes) - added by n0nam3 23 months ago.
patch for ticket fix

Download all attachments as: .zip

Change History (7)

comment:1 Changed 23 months ago by bmispelon

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Hi,

Thanks for the report, it does appear that the help text is incorrect.

For reference, here's the method where the project/app template handling happens: https://github.com/django/django/blob/master/django/core/management/templates.py#L187

As for your proposed correction, it looks good to me, though I would write "URL" instead of "url".

comment:2 Changed 23 months ago by n0nam3

  • Owner changed from nobody to n0nam3
  • Status changed from new to assigned

Changed 23 months ago by n0nam3

patch for ticket fix

comment:3 Changed 23 months ago by n0nam3

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 22 months ago by bmispelon

The patch looks good so I'm leaving it as "Ready for checkin" but next time you shouldn't mark your own patch as RFC.

See https://docs.djangoproject.com/en/1.5/internals/contributing/triaging-tickets/#how-can-i-help-with-triaging.

Thanks.

comment:5 Changed 22 months ago by claudep

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 22 months ago by anonymous

I also made a pull request in Github. Should I have marked the patch as "Fixed on branch"? I'll close the pull request now that it's fixed.
Thanks.

Note: See TracTickets for help on using tickets.
Back to Top