#20256 closed Bug (fixed)
Incorrect text in startproject command line help
| Reported by: | anonymous | Owned by: | n0nam3 |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The command line help for startproject django-admin.py startproject --help is
--template=TEMPLATE The dotted import path to load the template from.
The directory need not to be importable and should not be dotted but a path with "/".
--- a/django/core/management/templates.py
+++ b/django/core/management/templates.py
@@ -43,7 +43,7 @@ class TemplateCommand(BaseCommand):
option_list = BaseCommand.option_list + (
make_option('--template',
action='store', dest='template',
- help='The dotted import path to load the template from.'),
+ help='The path or url to load the template from.'),
make_option('--extension', '-e', dest='extensions',
action='append', default=['py'],
help='The file extension(s) to render (default: "py"). '
Attachments (1)
Change History (7)
comment:1 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 13 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:4 by , 13 years ago
The patch looks good so I'm leaving it as "Ready for checkin" but next time you shouldn't mark your own patch as RFC.
Thanks.
comment:5 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed in master [de8aa3a9a9098af35d5b56442c39dd2ed56b3299].
comment:6 by , 13 years ago
I also made a pull request in Github. Should I have marked the patch as "Fixed on branch"? I'll close the pull request now that it's fixed.
Thanks.
Note:
See TracTickets
for help on using tickets.
Hi,
Thanks for the report, it does appear that the help text is incorrect.
For reference, here's the method where the project/app template handling happens: https://github.com/django/django/blob/master/django/core/management/templates.py#L187
As for your proposed correction, it looks good to me, though I would write "URL" instead of "url".