Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#20256 closed Bug (fixed)

Incorrect text in startproject command line help

Reported by: anonymous Owned by: n0nam3
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The command line help for startproject django-admin.py startproject --help is

  --template=TEMPLATE   The dotted import path to load the template from.

The directory need not to be importable and should not be dotted but a path with "/".

--- a/django/core/management/templates.py
+++ b/django/core/management/templates.py
@@ -43,7 +43,7 @@ class TemplateCommand(BaseCommand):
     option_list = BaseCommand.option_list + (
         make_option('--template',
                     action='store', dest='template',
-                    help='The dotted import path to load the template from.'),
+                    help='The path or url to load the template from.'),
         make_option('--extension', '-e', dest='extensions',
                     action='append', default=['py'],
                     help='The file extension(s) to render (default: "py"). '

Attachments (1)

incorrect_text.diff (737 bytes ) - added by n0nam3 11 years ago.
patch for ticket fix

Download all attachments as: .zip

Change History (7)

comment:1 by Baptiste Mispelon, 11 years ago

Triage Stage: UnreviewedAccepted

Hi,

Thanks for the report, it does appear that the help text is incorrect.

For reference, here's the method where the project/app template handling happens: https://github.com/django/django/blob/master/django/core/management/templates.py#L187

As for your proposed correction, it looks good to me, though I would write "URL" instead of "url".

comment:2 by n0nam3, 11 years ago

Owner: changed from nobody to n0nam3
Status: newassigned

by n0nam3, 11 years ago

Attachment: incorrect_text.diff added

patch for ticket fix

comment:3 by n0nam3, 11 years ago

Triage Stage: AcceptedReady for checkin

comment:4 by Baptiste Mispelon, 11 years ago

The patch looks good so I'm leaving it as "Ready for checkin" but next time you shouldn't mark your own patch as RFC.

See https://docs.djangoproject.com/en/1.5/internals/contributing/triaging-tickets/#how-can-i-help-with-triaging.

Thanks.

comment:5 by Claude Paroz, 11 years ago

Resolution: fixed
Status: assignedclosed

comment:6 by anonymous, 11 years ago

I also made a pull request in Github. Should I have marked the patch as "Fixed on branch"? I'll close the pull request now that it's fixed.
Thanks.

Note: See TracTickets for help on using tickets.
Back to Top