Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#20249 closed Bug (fixed)

Tutorial part 5 uses broken undocumented feature

Reported by: Baptiste Mispelon Owned by: nobody
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: tinodb Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As reported in #20241, passing callable arguments to a queryset's filter method doesn't actually work the way it's described in the tutorial [1].

It's also an undocumented feature (#11629).

[1] https://github.com/django/django/blob/master/docs/intro/tutorial05.txt#L408-L411

Change History (5)

comment:1 by tinodb, 11 years ago

Cc: tinodb added
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

comment:2 by Baptiste Mispelon, 11 years ago

Has patch: set

Here's a first attempt at rewriting the documentation: https://github.com/django/django/pull/1025

comment:3 by Baptiste Mispelon, 11 years ago

After some comments from Jacob on IRC, I changed the approach and modified the pull request.

His concerns were that the added code was distracting the reader from the real purpose of that part of the tutorial (testing).

This new version changes the part 4 of the tutorial to make the changes introduced in the 5th part more seamless and less awkward.

For reference, I kept the older version on a different branch: https://github.com/bmispelon/django/compare/master...ticket-20249-backup.

comment:4 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: newclosed

In 679a2ac843567d32c95ccc46a215bc453ccfa2d0:

Fixed #20249 - Removed a "feature" in the tutorial that doesn't actually work.

Thanks bmispelon for the report and draft patch.

comment:5 by Tim Graham <timograham@…>, 11 years ago

In 13de270bd52d057584023de08ea869722a7e5d5a:

[1.5.X] Fixed #20249 - Removed a "feature" in the tutorial that doesn't actually work.

Thanks bmispelon for the report and draft patch.

Backport of 679a2ac843 from master

Note: See TracTickets for help on using tickets.
Back to Top