Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20168 closed Cleanup/optimization (fixed)

PostgreSQL specific example in documentation

Reported by: russellm Owned by: nobody
Component: Documentation Version: 1.5
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The documentation on Custom manager objects uses an example for a custom method that opens a database cursor. However, the example uses a PostgreSQL-specific SQL dialect in the GROUP BY clause (the use of column numbers in the GROUP BY clause).

This is potentially confusing; using a more conventional GROUP BY clause referencing column names would be no less confusing for PostgreSQL users, but would make sense to those coming from other databases.

Change History (2)

comment:1 Changed 2 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In c119d0f152e939420613868294d58fa4b902e18a:

Fixed #20168 - Generalized a PostgreSQL specific database query in the docs.

Thanks Russ for the suggestion.

comment:2 Changed 2 years ago by Tim Graham <timograham@…>

In a825b1903d355f8f7f41123fc36deb71d98db665:

[1.5.x] Fixed #20168 - Generalized a PostgreSQL specific database query in the docs.

Thanks Russ for the suggestion.

Backport of c119d0f152 from master

Note: See TracTickets for help on using tickets.
Back to Top