#20158 closed Bug (fixed)
Test models for pickled querysets have invalid code
| Reported by: | Baptiste Mispelon | Owned by: | Baptiste Mispelon |
|---|---|---|---|
| Component: | Testing framework | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The models located in tests/queryset_pickle/models.py use some defaults that can't actually be called.
This doesn't show when running the tests because no models are actually created so the problematic functions are never called.
The standalone_number function and the Numbers.get_static_number static method shouldn't actually take any parameter.
Change History (3)
comment:1 by , 11 years ago
| Has patch: | set |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
PR here: https://github.com/django/django/pull/975
I fixed both function's signatures and added a
setUpmethod on the testcase that creates aHappeninginstance.