Code

Opened 13 months ago

Last modified 5 months ago

#20133 new New feature

Admin: Add deletion summary

Reported by: jonash Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Here's a first version of a patch that adds a short modelname => number-of-deleted-objects-of-that-model map to the admin object deletion confirmation page.

http://i.imgur.com/g5Ltqzc.png

The patch is by no means RFC, it's only meant to be a first sketch in order to get feedback about the idea in general. I've also done some refactoring as preparation for implementing this feature. To be specific, there was some code that mixed logic and presentation that is now a bit more separated; although there's still potential to reduce complexity by factoring get_deleted_objects *into* the views (i.e. removing the helper function entirely).

Attachments (1)

patch1.patch (15.0 KB) - added by jonash 13 months ago.

Download all attachments as: .zip

Change History (6)

Changed 13 months ago by jonash

comment:1 Changed 13 months ago by julien

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Great idea!

comment:2 Changed 13 months ago by jonash

Any comments on the patch or the idea in general? Feature requests? Site design/structure?

comment:3 Changed 13 months ago by jonash

Btw there's some serious DRY violation in that particular area of the admin, both in the views and templates. If anyone with a bit more knowledge of the admin code base has any tips on how to refactor this, please let me know.

comment:4 Changed 7 months ago by jonash

bump

comment:5 Changed 5 months ago by jonash

bump

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new
The owner will be changed from nobody to anonymous. Next status will be 'assigned'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.