Opened 12 years ago

Closed 12 years ago

#20130 closed Bug (fixed)

cache tag doesn't resolve fragment name

Reported by: FunkyBob Owned by: Baptiste Mispelon
Component: Template system Version: dev
Severity: Release blocker Keywords:
Cc: bmispelon@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

All arguments passed to the CacheNode are run through parser.compile_filter, but when building the cache key, fragment_name is not resolved.

This works because FilterExpression.str returns self.token... however, creating the filter expression is a waste of work if we're not going to use it.

The fix is either to not call compile_filter on this argument, OR to call resolve on fragment_name before using it.

Change History (6)

comment:2 by Russell Keith-Magee, 12 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Version: 1.5 → master

This appears to be a regression in the handling of the fragment name.

comment:3 by Baptiste Mispelon, 12 years ago

Cc: bmispelon@… added
Owner: changed from nobody to Baptiste Mispelon
Status: new → assigned

comment:4 by Baptiste Mispelon, 12 years ago

Has patch: set

PR ready: ​https://github.com/django/django/pull/954

comment:5 by Baptiste Mispelon, 12 years ago

I updated the PR to add a regression test.

comment:6 by Florian Apolloner <florian@…>, 12 years ago

Resolution: → fixed
Status: assigned → closed

In 5080311998a8ecc5b3f9fa162c19e55b70aa9f85:

Fixed #20130 -- Regression in {% cache %} template tag.

Note: See TracTickets for help on using tickets.
Back to Top