Opened 4 years ago

Closed 4 years ago

#20130 closed Bug (fixed)

cache tag doesn't resolve fragment name

Reported by: FunkyBob Owned by: Baptiste Mispelon
Component: Template system Version: master
Severity: Release blocker Keywords:
Cc: bmispelon@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


All arguments passed to the CacheNode are run through parser.compile_filter, but when building the cache key, fragment_name is not resolved.

This works because FilterExpression.str returns self.token... however, creating the filter expression is a waste of work if we're not going to use it.

The fix is either to not call compile_filter on this argument, OR to call resolve on fragment_name before using it.

Change History (6)

comment:1 Changed 4 years ago by FunkyBob

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 4 years ago by Russell Keith-Magee

Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted
Version: 1.5master

This appears to be a regression in the handling of the fragment name.

comment:3 Changed 4 years ago by Baptiste Mispelon

Cc: bmispelon@… added
Owner: changed from nobody to Baptiste Mispelon
Status: newassigned

comment:4 Changed 4 years ago by Baptiste Mispelon

Has patch: set

comment:5 Changed 4 years ago by Baptiste Mispelon

I updated the PR to add a regression test.

comment:6 Changed 4 years ago by Florian Apolloner <florian@…>

Resolution: fixed
Status: assignedclosed

In 5080311998a8ecc5b3f9fa162c19e55b70aa9f85:

Fixed #20130 -- Regression in {% cache %} template tag.

Note: See TracTickets for help on using tickets.
Back to Top