Opened 12 years ago
Closed 12 years ago
#20121 closed Cleanup/optimization (fixed)
LogEntry.get_admin_url uses a hard-coded path format.
Reported by: | floppya | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Simon Charette | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | no |
Description
The LogEntry model from contrib.admin assumes that admin change path for a ContentType always follows the {{app_name}}/{{model_name}}/{{id}}/ format. This causes incorrect links to be generated for the admin change log in cases where the model's change url is customized.
Change History (3)
comment:1 by , 12 years ago
Easy pickings: | set |
---|---|
Has patch: | set |
comment:2 by , 12 years ago
Cc: | added |
---|---|
Patch needs improvement: | set |
Triage Stage: | Unreviewed → Accepted |
Type: | Bug → Cleanup/optimization |
The cleanup makes sense but the provided patch makes two regression tests fails.
comment:3 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Github topic branch: https://github.com/floppya/django/tree/ticket_20121