Opened 2 years ago

Closed 2 years ago

#20067 closed Cleanup/optimization (invalid)

Managet Queryset Typo

Reported by: Ramces Chirino <ramces@…> Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The documentation method to override the default Model Manager queryset is incorrect in the dev version. This method begins to appear after Modifying Initial Manager QuerySets (https://docs.djangoproject.com/en/dev/topics/db/managers/#modifying-initial-manager-querysets), and continue throughout the page.

Incorrect version
Manager.get_queryset()

Correct version
Manager.get_query_set()

I confirmed this appears correctly in v1.4 and v1.5 documentation. The error is only in the dev version.

Change History (2)

comment:1 Changed 2 years ago by akaariai

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Cleanup/optimization
  • Version changed from 1.5 to master

The method's name has been changed for consistency throughout Django. In 1.5 and earlier methods/properties were sometimes spelled query_set but in most places queryset. So, get_query_set has been renamed to get_queryset in the development version.

I think a versionchanged note in there would be useful, so marking as accepted.

comment:2 Changed 2 years ago by aaugustin

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.
Back to Top