Opened 2 years ago

Closed 2 years ago

#20061 closed Cleanup/optimization (fixed)

Out of date comment in contrib/humanize/tests.py

Reported by: bmispelon Owned by: bmispelon
Component: contrib.humanize Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The comment for the HumanizeTests.humanize_tester reads:

# Using max below ensures we go through both lists
# However, if the lists are not equal length, this raises an exception

This was actually changed in commit 9ad005ec1c50e254dd61bbb1760c524aa01a79e2.

See https://github.com/django/django/commit/9ad005ec1c50e254dd61bbb1760c524aa01a79e2#L0L35

Change History (3)

comment:1 Changed 2 years ago by bmispelon

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to bmispelon
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 2 years ago by bmispelon

  • Type changed from Uncategorized to Cleanup/optimization

comment:3 Changed 2 years ago by bmispelon

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.
Back to Top