Opened 11 years ago

Closed 11 years ago

#20055 closed Bug (fixed)

Admin CSS missing styles for input type=number

Reported by: Florian Apolloner Owned by: Baptiste Mispelon
Component: contrib.admin Version: dev
Severity: Release blocker Keywords:
Cc: bmispelon@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Change History (5)

comment:1 by Florian Apolloner, 11 years ago

Component: Uncategorizedcontrib.admin
Type: UncategorizedBug

comment:2 by Claude Paroz, 11 years ago

From the 1.6 release notes:
If your CSS/Javascript code used to access HTML input widgets by type, you should review it as type='text' widgets might be now output as type='email', type='url' or type='number' depending on their corresponding field type.

Let's eat our own dogfood!

comment:3 by Baptiste Mispelon, 11 years ago

Cc: bmispelon@… added
Has patch: set
Owner: changed from nobody to Baptiste Mispelon
Status: newassigned

The fix is quite easy since there's only one instance of input[type=text] in the CSS.

I just added selectors for email, url, and number input types, as the release notes advise.

https://github.com/django/django/pull/907

comment:4 by Claude Paroz, 11 years ago

Triage Stage: AcceptedReady for checkin

comment:5 by Simon Charette <charette.s@…>, 11 years ago

Resolution: fixed
Status: assignedclosed

In 0122a98dad6a7785def47466814ed2ae8d244143:

Fixed #20055 -- Add url, email, and number input types to admin CSS.

Note: See TracTickets for help on using tickets.
Back to Top