Code

#20055 closed Bug (fixed)

Admin CSS missing styles for input type=number

Reported by: apollo13 Owned by: bmispelon
Component: contrib.admin Version: master
Severity: Release blocker Keywords:
Cc: bmispelon@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Attachments (0)

Change History (5)

comment:1 Changed 16 months ago by apollo13

  • Component changed from Uncategorized to contrib.admin
  • Type changed from Uncategorized to Bug

comment:2 Changed 16 months ago by claudep

From the 1.6 release notes:
If your CSS/Javascript code used to access HTML input widgets by type, you should review it as type='text' widgets might be now output as type='email', type='url' or type='number' depending on their corresponding field type.

Let's eat our own dogfood!

comment:3 Changed 16 months ago by bmispelon

  • Cc bmispelon@… added
  • Has patch set
  • Owner changed from nobody to bmispelon
  • Status changed from new to assigned

The fix is quite easy since there's only one instance of input[type=text] in the CSS.

I just added selectors for email, url, and number input types, as the release notes advise.

https://github.com/django/django/pull/907

comment:4 Changed 16 months ago by claudep

  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 16 months ago by Simon Charette <charette.s@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 0122a98dad6a7785def47466814ed2ae8d244143:

Fixed #20055 -- Add url, email, and number input types to admin CSS.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.