Opened 3 years ago

Closed 3 years ago

#20039 closed Bug (fixed)

_has_changed broken for TypedChoiceFields

Reported by: apollo13 Owned by: Claude Paroz <claude@…>
Component: Forms Version: master
Severity: Release blocker Keywords: regression, forms, has_changed
Cc: claudep Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


See the attached test, if the field is required _has_changed will return early…

Attachments (2)

_has_changed_failure.diff (726 bytes) - added by apollo13 3 years ago.
20039-1.diff (4.3 KB) - added by claudep 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by apollo13

comment:1 Changed 3 years ago by claudep

#19643 is related. There is basically something wrong with to_python calling super.validate while self.validate is a noop.

Changed 3 years ago by claudep

comment:2 Changed 3 years ago by claudep

  • Has patch set
  • Version changed from 1.5 to master

comment:3 Changed 3 years ago by apollo13

  • Triage Stage changed from Accepted to Ready for checkin

The attached patch fixes my issues on the live site :)

comment:4 Changed 3 years ago by Claude Paroz <claude@…>

  • Owner set to Claude Paroz <claude@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 9883551d50e105b324d8071232bf420935844e43:

Fixed #20039 -- Fixed has_changed form detection for required TypedChoiceFields

Thanks Florian Apolloner for the report and the review.
Also fixes #19643.

Note: See TracTickets for help on using tickets.
Back to Top