Opened 3 years ago

Closed 3 years ago

#20010 closed Bug (fixed)

Tests for CaptureQueriesContext fail under Oracle

Reported by: aaugustin Owned by: charettes
Component: Testing framework Version: master
Severity: Release blocker Keywords:
Cc: apollo13 Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


These tests were introduced in 952ba5237ea62e7647cdd5214b1df79c0e7cea38. They rely on query parameters being listed in connection._last_executed_query, which doesn't appear to be true under Oracle.

Two solutions:

  • change the tests for CaptureQueriesContext
  • change _last_executed_query to be more like SQLite

Attachments (1)

0001-Fixed-20010-Make-sure-last_executed_query-contains-i.patch (2.4 KB) - added by charettes 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 3 years ago by apollo13

  • Cc apollo13 added

comment:2 Changed 3 years ago by charettes

  • Owner changed from nobody to charettes
  • Status changed from new to assigned

I guess I should fix my own mess. I think I'll favor the behave-more-like-SQLite approach.

comment:3 Changed 3 years ago by charettes

Added a patch I can't test.

comment:4 Changed 3 years ago by charettes

  • Has patch set

comment:5 Changed 3 years ago by aaugustin

  • Triage Stage changed from Accepted to Ready for checkin

Tests pass with this patch under Oracle.

Do you think it's useful to add a line in the "backwards incompatible changes" section of the release notes?

comment:6 Changed 3 years ago by charettes

That can't hurt, I'll adjust the patch.

comment:7 Changed 3 years ago by charettes

Wondering if it's worth it, the change to SQLite3 wasn't documented AFAIK 6605ac331a9e03fa41c301d122c5727c0d98b970.

comment:8 Changed 3 years ago by aaugustin

It's your call!

comment:9 Changed 3 years ago by Simon Charette <charette.s@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In bc7a10299f7ad7f468fa78d5990b7b545d4d599d:

Fixed #20010 -- Make sure last_executed_query contains it's associated parameters on Oracle.

Also removed some unused imports.

Note: See TracTickets for help on using tickets.
Back to Top