Code

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1998 closed enhancement (fixed)

[patch] MIDDLEWARE_CLASSES should be single-quoted

Reported by: nirvdrum Owned by: adrian
Component: Core (Other) Version:
Severity: trivial Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A minor issue, but all of the values in the default settings.py file are single-quoted except for the MIDDLEWARE_CLASSES one. For consistency's sake, I recommend making it single-quoted as well.

Attachments (2)

single-quotes.diff (1.8 KB) - added by nirvdrum 8 years ago.
single-quotes-plus-docs.diff (5.4 KB) - added by nirvdrum 8 years ago.
Same as single-quotes.diff but updates the django documentation as well

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

I don't really think this is a big deal.

Changed 8 years ago by nirvdrum

comment:2 Changed 8 years ago by anonymous

  • Summary changed from MIDDLEWARE_CLASSES should be single-quoted to [patch] MIDDLEWARE_CLASSES should be single-quoted

comment:3 Changed 8 years ago by anonymous

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Reopening since I've now attached a patch. I probably should have done this to begin with, but I wasn't sure how easy it'd be. The overall issue is still minor, but then again, django is for perfectionists.

Changed 8 years ago by nirvdrum

Same as single-quotes.diff but updates the django documentation as well

comment:4 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [2980].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.