#19916 closed Bug (fixed)

contrib.comments's templatetags use token.contents.split()

Reported by: bmispelon Owned by: bmispelon
Component: contrib.comments Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by aaugustin)

This is the same bug as #19882, but for the template tags of contrib.comments.

It's caused by using token.contents.split() instead of token.split_contents(), causing problems when a variable has a filter with an argument that contains spaces.

Attachments (0)

Change History (5)

comment:1 Changed 17 months ago by carljm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 17 months ago by aaugustin

  • Description modified (diff)

comment:3 Changed 17 months ago by bmispelon

  • Has patch set
  • Status changed from new to assigned

comment:4 Changed 17 months ago by aaugustin

  • Triage Stage changed from Accepted to Ready for checkin

[rhetorical question] Do we really need that many tests to test such a trivial change?

comment:5 Changed 16 months ago by claudep

  • Resolution set to fixed
  • Status changed from assigned to closed

Pull request merged in 81804ae474d6fe5d3ab9348cfe86ee3779473a2a (Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments. )

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.