Opened 11 years ago
Closed 11 years ago
#19916 closed Bug (fixed)
contrib.comments's templatetags use token.contents.split()
| Reported by: | Baptiste Mispelon | Owned by: | Baptiste Mispelon |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This is the same bug as #19882, but for the template tags of contrib.comments.
It's caused by using token.contents.split() instead of token.split_contents(), causing problems when a variable has a filter with an argument that contains spaces.
Change History (5)
comment:1 by , 11 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 11 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 11 years ago
| Has patch: | set |
|---|---|
| Status: | new → assigned |
comment:4 by , 11 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
[rhetorical question] Do we really need that many tests to test such a trivial change?
comment:5 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Pull request merged in 81804ae474d6fe5d3ab9348cfe86ee3779473a2a (Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments. )
Note:
See TracTickets
for help on using tickets.
Pull request here: https://github.com/django/django/pull/850