form-wizard initial data example is wrong

[almalki]

In this ​example there is a small error, basically it is calling as_view and then call methods on the returned function.

>>> wiz = ContactWizard.as_view([ContactForm1, ContactForm2], initial_dict=initial)
>>> form1 = wiz.get_form('0')

should be:

>>> wiz = ContactWizard([ContactForm1, ContactForm2], initial_dict=initial)
>>> form1 = wiz.get_form('0')

(assuming __init__ takes same arguments as as_view)

[Carl Meyer]

#19886 was a duplicate.

[expleo]

Fixed in pull request: ​https://github.com/django/django/pull/752

[Tim Graham]

Whoops, I had meant to comment on this but I left the comment on the duplicate ticket instead.

You can't initialize ContactWizard directly with a list of forms and the initial dict. The as_view call is correct, but then you need to pass request to the function that's returned. Maybe RequestFactory could be used for the example, but a session is also needed on the request so it seems a bit complicated to have this example use the shell.

[expleo]

Replying to timo:

Whoops, I had meant to comment on this but I left the comment on the duplicate ticket instead.

You can't initialize ContactWizard directly with a list of forms and the initial dict. The as_view call is correct, but then you need to pass request to the function that's returned. Maybe RequestFactory could be used for the example, but a session is also needed on the request so it seems a bit complicated to have this example use the shell.

I agree, not changing the docs seems the best option in this case.

[Tim Graham]

I think we should make some sort of fix since it's misleading as is. How about the attached?

[Tim Graham <timograham@…>]

In a97c441e18684570fbecd47b19bd47b4c06cc565:

[1.5.X] Fixed #19880 - Fixed an error in the form wizard initial_dict example.

Thanks almalki for the report.

Backport of 9b97f01dea from master

[Tim Graham <timograham@…>]

In 9b97f01dea093de484366924842c89550472d0b6:

Fixed #19880 - Fixed an error in the form wizard initial_dict example.

Thanks almalki for the report.