Deleting a protected fk relationships throws error 500 when deleting inlines

[Rafael Ponieman]

Better explained with an example.

We have 3 models, Category, Subcategory and Item. Subcategory has a protected (on_delete=models.PROTECT) fk relationship to Category, and Item has a protected fk relationship to Subcategory.

When trying to delete a Category that has Subcategories, the Django admin displays a readable, understandable message explaining that the model instance has related models, so it can't be deleted. However, if the Subcategories are displayed as inlines in the Category admin, and one tries to delete a Subcategory that has related items, Django throws an uncatched error 500, instead of a human-readable message.

[Rafael Ponieman]

It is clear in the documentation that models.PROTECT will raise an exception, however, it is nicely caught on the regular ModelAdmin, but not on inlines.

[javimansilla]

Pull request added: ​https://github.com/django/django/pull/797

[anonymous]

PR review WIP at ​https://github.com/ramiro/django/compare/master...19838-protected-fk-not-raising-errors-on-delete

[Ramiro Morales <cramm0@…>]

In 3ea0c7d35ac461cb469170486683d10732eb534b:

Fixed #19838 -- Admin: Don't leak a 500 HTTP status when trying to delete protected FKs.

Thanks rafadev for the report and Javier Mansilla for the fix.