Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#19812 closed Cleanup/optimization (fixed)

Duplicate phrase in documentation of MultiWidget

Reported by: Diego Andrés Sanabria Martín Owned by: itsallvoodoo
Component: Documentation Version: 1.5-rc-1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The documentation in https://docs.djangoproject.com/en/1.5/ref/forms/widgets/#django.forms.MultiWidget.render repeats a couple of phrases:

If value is a list, output of render() will be a concatenation of rendered child widgets. If value is not a list, it will be first processed by the method decompress() to create the list and then processed as above.

In the second case – i.e., if the value is not a list – render() will first decompress the value into a list before rendering it. It does so by calling the decompress() method, which MultiWidget‘s subclasses must implement (see above).

Change History (11)

comment:1 Changed 4 years ago by Diego Andrés Sanabria Martín

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Alos happens in documentation of django 1.4

comment:2 Changed 4 years ago by anonymous

Triage Stage: UnreviewedAccepted

comment:3 Changed 4 years ago by itsallvoodoo

Owner: changed from nobody to itsallvoodoo
Status: newassigned

comment:4 Changed 4 years ago by itsallvoodoo

Easy pickings: set

comment:5 Changed 4 years ago by itsallvoodoo

Triage Stage: AcceptedReady for checkin

comment:6 Changed 4 years ago by itsallvoodoo

Instructions have been edited and pull request has been submitted.

comment:7 Changed 4 years ago by Claude Paroz

Triage Stage: Ready for checkinAccepted

I don't see any pull request link in this ticket. And you shouldn't set Ready for checkin for your own patches.

comment:8 Changed 4 years ago by itsallvoodoo

I am sorry, going through the learning process here. This is my first ticket patch ever. Thanks for pointing that out.

Pull request link:
https://github.com/django/django/pull/727

Last edited 4 years ago by itsallvoodoo (previous) (diff)

comment:9 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 7a80904b002a1983282c7dfa3ac05046098242ce:

Fixed #19812 - Removed a duplicate phrase in the widget docs.

Thanks diegueus9 for the report and itsallvoodoo for the draft patch.

comment:10 Changed 4 years ago by Tim Graham <timograham@…>

In ad2b091c1f48687188295e57b5cf4f6ad751f572:

[1.5.x] Fixed #19812 - Removed a duplicate phrase in the widget docs.

Thanks diegueus9 for the report and itsallvoodoo for the draft patch.

Backport of 7a80904b00 from master

comment:11 Changed 4 years ago by Tim Graham <timograham@…>

In 83e512fa6e45d2c9e63735bb0c3cd8f1fcd2e616:

[1.4.x] Fixed #19812 - Removed a duplicate phrase in the widget docs.

Thanks diegueus9 for the report and itsallvoodoo for the draft patch.

Backport of 7a80904b00 from master

Note: See TracTickets for help on using tickets.
Back to Top