Opened 2 years ago

Closed 2 years ago

#19810 closed Bug (fixed)

MemcachedCache should use pickle.HIGHEST_PROTOCOL

Reported by: fernandogrd@… Owned by: bpeschier
Component: Core (Cache system) Version: master
Severity: Normal Keywords: sprint2013
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

MemcachedCache does not specify pickle protocol, and python-memcached defaults to version 0. Since others backends use HIGHEST_PROTOCOL, MemcachedCache should use too, to keep the standard.

Related to #16378 (ticket)

Change History (12)

comment:1 Changed 2 years ago by fernandogrd@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 2 years ago by anonymous

  • Has patch set

comment:3 Changed 2 years ago by claudep

  • Triage Stage changed from Unreviewed to Accepted

Accepting based on the discussion on #16378.

comment:4 Changed 2 years ago by lvh_

  • Needs tests set

There should probably be a test that checks that it actually uses HIGHEST_PROTOCOL :)

comment:5 Changed 2 years ago by lvh_

  • Owner changed from nobody to lvh_
  • Status changed from new to assigned

comment:6 Changed 2 years ago by lvh_

  • Owner lvh_ deleted
  • Status changed from assigned to new

comment:7 Changed 2 years ago by aaugustin

#11011 was a duplicate.

comment:8 Changed 2 years ago by bpeschier

  • Keywords sprint2013 added
  • Owner set to bpeschier
  • Status changed from new to assigned

comment:9 Changed 2 years ago by aaugustin

It looks like #15815 is the same thing, or at least very closely related.

comment:10 Changed 2 years ago by bpeschier

comment:11 Changed 2 years ago by bpeschier

  • Needs tests unset

comment:12 Changed 2 years ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 5a9b2bce242bd2f8a9fed6ac735406ce68b10738:

Fixed #19810 -- MemcachedCache now uses pickle.HIGHEST_PROTOCOL

Note: See TracTickets for help on using tickets.
Back to Top