[patch] Wrong URL for timezone advice in settings.py

[Joeboy]

The boilerplate settings.py contains the following advice:

# Local time zone for this installation. All choices can be found here:

# ​http://www.postgresql.org/docs/current/static/datetime-keywords.html#DATETIME-TIMEZONE-SET-TABLE

I looked at that list and naively set my timezone to 'Europe/London GB GB-Eire'. Consequently my (mysql) database lookups broke in a confusing way. Setting it to just 'Europe/London' instead fixed the problem.

Cheers.

[Malcolm Tredinnick]

To explain a bit more what the problem here is: if you set the timezone to 'Europe/London' then all the date/time functions respect DST settings. With a string like 'Europe/London GB GB-Eire', it is internally mapped to something like "UTC + 0 always" at some level (not sure whether it's in the Python library or the C library). So, today, the longer setting for TIME_ZONE will mean that datetime.datetime.now() inside Django will be wrong (due to daylight savings being in effect in London).

PostgreSQL is too flexible in what it accepts. C libraries, not so much.

[nirvdrum]

I dunno about that. If you read the text just before the table, you see "In many cases there are several equivalent names for the same zone. These are listed on the same line."

The confusing part is that they don't say the names are separated by spaces (I guess that's to be inferred by the use of slashes for linking names). I think the documentation says that each of those names are equivalent, however.

[Adrian Holovaty]

(In [3297]) Fixed #1977 -- Added clarification about TIME_ZONE setting.

[anonymous]

The link given in settings.py no longer is correct, since PostGres 8.2 came out.

The CORRECT link is

​http://www.postgresql.org/docs/8.1/static/datetime-keywords.html#DATETIME-TIMEZONE-SET-TABLE

NOT

​http://www.postgresql.org/docs/current/static/datetime-keywords.html#DATETIME-TIMEZONE-SET-TABLE

(current -> 8.1)

[Adrian Holovaty]

(In [4201]) Fixed #1977 -- Changed postgresql.org link regarding timezone choices in docs/settings.txt

[regexbot@…]

The issue still exists in django/conf/project_template/settings.py... ;-)

[regexbot@…]

patch for timezone link in settings.py boilerplate

[regexbot@…]

Patch attached.

[Adrian Holovaty]

(In [4207]) Fixed #1977 -- Changed postgresql.org URL in global_settings.py and project_template/settings.py. Thanks, regexbot@…