Opened 12 years ago
Closed 11 years ago
#19740 closed Bug (fixed)
Make sure only posts not marked as defunct show up in feed
Reported by: | Aymeric Augustin | Owned by: | nobody |
---|---|---|---|
Component: | *.djangoproject.com | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
[originally reported by jezdez at https://github.com/django/djangoproject.com/issues/27]
jezdez
A bunch of feeds from David Larlet's blog showed up in the feed even though the feed object was marked as defunct.
aaugustin
defunct is used only in django_website.aggregator.templatetags.aggregator
, and that module is dead code -- the {% get_feed_list %}
tag doesn't appear to be used anywhere.
Jacob says the proper fix is to add a try/catch around the call to unsubscribe:
https://github.com/django/djangoproject.com/blob/master/django_website/aggregator/models.py#L37
Change History (5)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Has patch: | set |
---|
Here's an untested PR.
Also a related cleanup to remove is_defunct
.
comment:5 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
From brutasse on this pull request: