Opened 2 years ago

Closed 21 months ago

#19740 closed Bug (fixed)

Make sure only posts not marked as defunct show up in feed

Reported by: aaugustin Owned by: nobody
Component: *.djangoproject.com Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

[originally reported by jezdez at https://github.com/django/djangoproject.com/issues/27]

jezdez

A bunch of feeds from David Larlet's blog showed up in the feed even though the feed object was marked as defunct.

http://jzdz.me/F5Mr

aaugustin

defunct is used only in django_website.aggregator.templatetags.aggregator, and that module is dead code -- the {% get_feed_list %} tag doesn't appear to be used anywhere.

Jacob says the proper fix is to add a try/catch around the call to unsubscribe:
https://github.com/django/djangoproject.com/blob/master/django_website/aggregator/models.py#L37

Change History (5)

comment:1 Changed 21 months ago by timo

From brutasse on this pull request:

the code only takes approval_status into account. Instead of marking feeds as defunct, their approval status should be set to 'denied'.

The is_defunct flag could probably be deleted completely. I believe it was used when dp.com was doing the polling.

comment:2 Changed 21 months ago by timo

  • Has patch set

Here's an untested PR.

Also a related cleanup to remove is_defunct.

comment:3 Changed 21 months ago by brutasse

@timo I just commented on both PRs.

comment:4 Changed 21 months ago by timo

Thanks, I've updated both per your comments.

comment:5 Changed 21 months ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from new to closed

In f4ce13eb3c4f79632bf62f17584d4d2a582db490/djangoproject.com:

Merge pull request #60 from django/19740a

Fixed #19740 -- Ensured that denied feeds are unsubscribed.

Note: See TracTickets for help on using tickets.
Back to Top