Opened 8 years ago

Closed 7 years ago

#19740 closed Bug (fixed)

Make sure only posts not marked as defunct show up in feed

Reported by: Aymeric Augustin Owned by: nobody
Component: * Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


[originally reported by jezdez at]


A bunch of feeds from David Larlet's blog showed up in the feed even though the feed object was marked as defunct.


defunct is used only in django_website.aggregator.templatetags.aggregator, and that module is dead code -- the {% get_feed_list %} tag doesn't appear to be used anywhere.

Jacob says the proper fix is to add a try/catch around the call to unsubscribe:

Change History (5)

comment:1 Changed 7 years ago by Tim Graham

From brutasse on this pull request:

the code only takes approval_status into account. Instead of marking feeds as defunct, their approval status should be set to 'denied'.

The is_defunct flag could probably be deleted completely. I believe it was used when was doing the polling.

comment:2 Changed 7 years ago by Tim Graham

Has patch: set

Here's an untested PR.

Also a related cleanup to remove is_defunct.

comment:3 Changed 7 years ago by Bruno Renié

@timo I just commented on both PRs.

comment:4 Changed 7 years ago by Tim Graham

Thanks, I've updated both per your comments.

comment:5 Changed 7 years ago by Aymeric Augustin <aymeric.augustin@…>

Resolution: fixed
Status: newclosed

In f4ce13eb3c4f79632bf62f17584d4d2a582db490/

Merge pull request #60 from django/19740a

Fixed #19740 -- Ensured that denied feeds are unsubscribed.

Note: See TracTickets for help on using tickets.
Back to Top