Opened 2 years ago

Closed 2 years ago

#19704 closed Cleanup/optimization (fixed)

Make use of new ungettext_lazy function at appropriate places

Reported by: void Owned by: nobody
Component: Internationalization Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There are two places at the codebase, where new possibilities of ungettext_lazy may make code prettier:

  1. django.contrib.comments.admin
  2. django.utils.timesince

There are hacks with lambdas at both places.

Change History (6)

comment:1 Changed 2 years ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 2 years ago by claudep

  • Component changed from Core (Other) to Internationalization

comment:3 Changed 2 years ago by void

  • Has patch set

I made pull request for the ticket: https://github.com/django/django/pull/702

comment:4 Changed 2 years ago by claudep

Thanks, notes added on the pull request.

comment:5 Changed 2 years ago by void

I updated pull request, fixing problems you've pointed out

comment:6 Changed 2 years ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from new to closed

In d18f796a481e79a3800d4672d6189e4c496cce3d:

Fixed #19704 -- Make use of new ungettext_lazy function at appropriate places

Note: See TracTickets for help on using tickets.
Back to Top