Opened 11 years ago

Closed 11 years ago

#19687 closed Bug (duplicate)

UnsaltedMD5PasswordHasher throws exception on verify() with md5$$SALT

Reported by: twig@… Owned by: nobody
Component: contrib.auth Version: 1.4
Severity: Normal Keywords: login
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


After upgrading from v1.2.7 to 1.4.3, users had no way of logging in.

I noticed that the UnsaltedMD5PasswordHasher.verify() was passing the wrong arguments to constant_time_compare(). The arg "encoded" includes the algorithm and prefix "md5$$", so we need to strip it out first.

Should change:

return constant_time_compare(encoded, encoded_2


return constant_time_compare(encoded[5:], encoded_2)

Change History (2)

comment:1 by twig@…, 11 years ago

I've made a pull request at

comment:2 by Claude Paroz, 11 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #18144

Note: See TracTickets for help on using tickets.
Back to Top