Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19609 closed Bug (fixed)

admin Inlines doesn't display help_text for readonly fields

Reported by: glic3rinu Owned by: viciu
Component: contrib.admin Version: master
Severity: Normal Keywords: admin inline help_text readonly
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

Admin inlines doesn't display help_text for readonly fields

Attachments (1)

19609.diff (4.6 KB) - added by glic3rinu 2 years ago.

Download all attachments as: .zip

Change History (12)

Changed 2 years ago by glic3rinu

comment:1 Changed 2 years ago by glic3rinu

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Type changed from Uncategorized to Bug

comment:2 Changed 2 years ago by glic3rinu

The provided patch 19609.diff fixes the issue and also has tests.

comment:3 Changed 2 years ago by glic3rinu

  • Easy pickings set

comment:4 Changed 2 years ago by glic3rinu

  • UI/UX set

comment:5 Changed 2 years ago by glic3rinu

  • Version changed from 1.5-beta-1 to master

comment:6 Changed 2 years ago by carljm

  • Triage Stage changed from Unreviewed to Accepted

comment:7 Changed 2 years ago by viciu

  • Owner changed from nobody to viciu
  • Status changed from new to assigned

comment:8 Changed 2 years ago by viciu

I've applied and tested provided patch.
All tests pass.

Pull request is here:

https://github.com/django/django/pull/778

comment:9 Changed 2 years ago by oinopion

  • Triage Stage changed from Accepted to Ready for checkin

Reviewed. Good for me.

comment:10 Changed 2 years ago by Wiktor Kolodziej <wiktor@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 67dd54dc841a93a67eac87dc13ed047d72f920dc:

Fixed #19609: admin Inlines doesn't display help_text for readonly fields

Refactoring: field was renamed to field_name, since flatten_fieldsets returns field name, not field.

Original patch from Marc Aymerich Gubern

comment:11 Changed 2 years ago by Honza Král <Honza.Kral@…>

In 692902b227b4aff8a4ec66fa8d4ac2d3128bcac0:

Merge pull request #778 from viciu/19609

Fixed #19609: admin Inlines doesn't display help_text for readonly fields

Note: See TracTickets for help on using tickets.
Back to Top